Repository navigation
Replace the action helper and modifier with bound methods and on - #293
Merged
Merged
Conversation
…e array extensions
phndiaye
requested review from
edouardmisset,
nathalieArnoux and
olxmpe
and removed request for
a team
November 2, 2026 15:23
Base automatically changed from
pn/cd-375-inject-to-service
to
feature/ember-upgrade-4-to-7
November 2, 2026 15:29
Replace the Ember array extensions with native arrays in the classic hyper-table
Move to Ember 6.12.1 and ember-cli 6.12.0
Bump ember-cli-typescript to ^5.3.0
JulienVannier66
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Templates: every
{{action}}helper/modifier in the classic hyper-table (views, facetting, column, index, filters/cell renderers; 11 files) becomesthis.x,(fn this.x args)or{{on "click" this.x}}. Classic components move theiractionshash entries toaction(fn), which binds and keeps the hash entry (sendstill works).bubbles=falseis kept asevent.stopPropagation()in the handler; handlers called with no args before (toggleEditing,setFieldCategory) get a wrapper or an explicitundefinedso the click event does not become their first argument. The filters-rendererresetchain (_super) moves to a_resetFiltersmethod so the override order is unchanged.Integration tests for each interaction were added first and pass on the old code (27 tests).
{{on}}on non-interactive elements addsno-invalid-interactivetemplate-lint errors (lint was already failing). Existing quirks left as is:existenceFilterChangedsets a read-only computed (asserts in dev), the focusout handler passes the event asautosave.Base: #292 (
pn/cd-375-inject-to-service). Part of CD-375, M2 wave 3.